Re: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
From: kernel test robot
Date: Fri Mar 15 2024 - 12:36:34 EST
Hi Lukasz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master next-20240315]
[cannot apply to krzk/for-next clk/clk-next soc/for-next rafael-pm/acpi-bus rafael-pm/devprop v6.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lukasz-Luba/OPP-OF-Export-dev_opp_pm_calc_power-for-usage-from-EM/20240314-220719
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240314140421.3563571-4-lukasz.luba%40arm.com
patch subject: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning()
config: i386-randconfig-141-20240315 (https://download.01.org/0day-ci/archive/20240316/202403160033.Kh6R75dh-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240316/202403160033.Kh6R75dh-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403160033.Kh6R75dh-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> kernel/power/energy_model.c:824:52: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
824 | dev_warn(dev, "Couldn't find Energy Model %d\n", ret);
| ^~~
include/linux/dev_printk.h:146:70: note: expanded from macro 'dev_warn'
146 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
kernel/power/energy_model.c:817:12: note: initialize the variable 'ret' to silence this warning
817 | int i, ret;
| ^
| = 0
1 warning generated.
vim +/ret +824 kernel/power/energy_model.c
800
801 /**
802 * em_dev_update_chip_binning() - Update Energy Model with new values after
803 * the new voltage information is present in the OPPs.
804 * @dev : Device for which the Energy Model has to be updated.
805 *
806 * This function allows to update easily the EM with new values available in
807 * the OPP framework and DT. It can be used after the chip has been properly
808 * verified by device drivers and the voltages adjusted for the 'chip binning'.
809 * It uses the "dynamic-power-coefficient" DT property to calculate the power
810 * values for EM. For power calculation it uses the new adjusted voltage
811 * values known for OPPs, which might be changed after boot.
812 */
813 int em_dev_update_chip_binning(struct device *dev)
814 {
815 struct em_perf_table __rcu *em_table;
816 struct em_perf_domain *pd;
817 int i, ret;
818
819 if (IS_ERR_OR_NULL(dev))
820 return -EINVAL;
821
822 pd = em_pd_get(dev);
823 if (!pd) {
> 824 dev_warn(dev, "Couldn't find Energy Model %d\n", ret);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki