Re: [PATCH][next] fs/9p: remove redundant pointer v9ses

From: Eric Van Hensbergen
Date: Fri Mar 15 2024 - 11:35:13 EST


On Mon, Mar 04, 2024 at 09:59:22PM +0900, Dominique Martinet wrote:
> Colin Ian King wrote on Thu, Feb 29, 2024 at 10:22:50PM +0000:
> > Pointer v9ses is being assigned the value from the return of inlined
> > function v9fs_inode2v9ses (which just returns inode->i_sb->s_fs_info).
> > The pointer is not used after the assignment, so the variable is
> > redundant and can be removed.
> >
> > Cleans up clang scan warnings such as:
> > fs/9p/vfs_inode_dotl.c:300:28: warning: variable 'v9ses' set but not
> > used [-Wunused-but-set-variable]
>
> Thanks for the patch!
>
> Eric, this appears to be for your -next tree as it doesn't build on
> master -- didn't notice the [next] in the subject line until I tried...
> (I've just build-checked on your tree and it appears correct there)
>
> >
> > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
>
> Reviewed-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
>
> --
> Dominique

Pulled into my for-next tree, will try to get into a part-2 pull
request. Thanks.

-eric