Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector

From: Arnaldo Carvalho de Melo
Date: Fri Mar 15 2024 - 10:53:47 EST


On Fri, Mar 15, 2024 at 03:48:58PM +0100, Daniel Bristot de Oliveira wrote:
> On 3/15/24 15:24, Daniel Bristot de Oliveira wrote:
> > Use tools/build/ makefiles to build latency-collector, inheriting
> > the benefits of it. For example: Before this patch, a missing
> > tracefs/traceevents headers will result in fail like this:
> >
> > -------------------------------- %< -------------------------------
>
> Oops, b4 is interpreting these ------ as the '---' separator, and is truncating
> the message. I will fix this in a v3.
>
> sorry.

Yeah, that confuses scripts, that separator.

But overall I tested various versions of your patches and they look ok.

That tools/build/ was done for other tools to use and so far some tools/
living projects use it: tools/objtool, tools/lib/subcmd, etc.

I just did a:

git grep tools\/build

And there is quite a few more I didn't realize have been using bits and
pieces, good.

- Arnaldo