Re: [syzbot] [sound?] possible deadlock in snd_timer_close_locked

From: syzbot
Date: Fri Mar 15 2024 - 09:34:14 EST


Hello,

syzbot tried to test the proposed patch but the build/boot failed:

: registered new interface driver port100
[ 7.829002][ T1] usbcore: registered new interface driver nfcmrvl
[ 7.837538][ T1] Loading iSCSI transport class v2.0-870.
[ 7.856507][ T1] virtio_scsi virtio0: 1/0/0 default/read/poll queues
[ 7.866977][ T1] ------------[ cut here ]------------
[ 7.868232][ T1] refcount_t: decrement hit 0; leaking memory.
[ 7.869519][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:31 refcount_warn_saturate+0xfa/0x1d0
[ 7.870990][ T1] Modules linked in:
[ 7.871688][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-syzkaller-09791-ge5eb28f6d1af-dirty #0
[ 7.876326][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
[ 7.878700][ T1] RIP: 0010:refcount_warn_saturate+0xfa/0x1d0
[ 7.879754][ T1] Code: b2 00 00 00 e8 27 5a f7 fc 5b 5d c3 cc cc cc cc e8 1b 5a f7 fc c6 05 f6 81 d3 0a 01 90 48 c7 c7 e0 a7 fd 8b e8 47 2e ba fc 90 <0f> 0b 90 90 eb d9 e8 fb 59 f7 fc c6 05 d3 81 d3 0a 01 90 48 c7 c7
[ 7.882789][ T1] RSP: 0000:ffffc90000066e18 EFLAGS: 00010246
[ 7.884154][ T1] RAX: 427762defa97e000 RBX: ffff888020edeb2c RCX: ffff8880166c8000
[ 7.885354][ T1] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ 7.886832][ T1] RBP: 0000000000000004 R08: ffffffff8157cf32 R09: fffffbfff1bf9650
[ 7.888655][ T1] R10: dffffc0000000000 R11: fffffbfff1bf9650 R12: ffffea0000843dc0
[ 7.889916][ T1] R13: ffffea0000843dc8 R14: 1ffffd40001087b9 R15: 0000000000000000
[ 7.893126][ T1] FS: 0000000000000000(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
[ 7.895114][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 7.896277][ T1] CR2: ffff88823ffff000 CR3: 000000000df32000 CR4: 00000000003506f0
[ 7.897638][ T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 7.900434][ T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 7.902939][ T1] Call Trace:
[ 7.904000][ T1] <TASK>
[ 7.904699][ T1] ? __warn+0x163/0x4b0
[ 7.905611][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 7.906808][ T1] ? report_bug+0x2b3/0x500
[ 7.907725][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 7.908788][ T1] ? handle_bug+0x3e/0x70
[ 7.909996][ T1] ? exc_invalid_op+0x1a/0x50
[ 7.910753][ T1] ? asm_exc_invalid_op+0x1a/0x20
[ 7.911517][ T1] ? __warn_printk+0x292/0x360
[ 7.912828][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 7.914043][ T1] ? refcount_warn_saturate+0xf9/0x1d0
[ 7.914947][ T1] __free_pages_ok+0xc36/0xd60
[ 7.916124][ T1] make_alloc_exact+0xa3/0xf0
[ 7.917078][ T1] vring_alloc_queue_split+0x20a/0x600
[ 7.918018][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 7.919870][ T1] ? vp_find_vqs+0x4c/0x4e0
[ 7.920839][ T1] ? virtscsi_probe+0x3ea/0xf60
[ 7.921640][ T1] ? virtio_dev_probe+0x991/0xaf0
[ 7.922633][ T1] ? really_probe+0x29e/0xc50
[ 7.923595][ T1] ? driver_probe_device+0x50/0x430
[ 7.925027][ T1] vring_create_virtqueue_split+0xc6/0x310
[ 7.926040][ T1] ? ret_from_fork+0x4b/0x80
[ 7.927657][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 7.929661][ T1] vring_create_virtqueue+0xca/0x110
[ 7.930785][ T1] ? __pfx_vp_notify+0x10/0x10
[ 7.931677][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 7.932523][ T1] setup_vq+0xe9/0x2d0
[ 7.933148][ T1] ? __pfx_vp_notify+0x10/0x10
[ 7.934298][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 7.936631][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 7.938514][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 7.939708][ T1] vp_setup_vq+0xbf/0x330
[ 7.940480][ T1] ? __pfx_vp_config_changed+0x10/0x10
[ 7.941952][ T1] ? ioread16+0x2f/0x90
[ 7.943383][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 7.945869][ T1] vp_find_vqs_msix+0x8b2/0xc80
[ 7.946930][ T1] vp_find_vqs+0x4c/0x4e0
[ 7.948366][ T1] virtscsi_init+0x8db/0xd00
[ 7.949444][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 7.950722][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 7.952485][ T1] ? scsi_host_alloc+0xa57/0xea0
[ 7.954177][ T1] ? vp_get+0xfd/0x140
[ 7.955309][ T1] virtscsi_probe+0x3ea/0xf60
[ 7.956670][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 7.958350][ T1] ? virtqueue_dma_mapping_error+0xd/0x80
[ 7.960113][ T1] ? __pfx_vp_set_status+0x10/0x10
[ 7.961499][ T1] ? vp_set_status+0x1a/0x40
[ 7.962431][ T1] ? virtio_no_restricted_mem_acc+0x9/0x10
[ 7.964349][ T1] ? virtio_features_ok+0x10c/0x270
[ 7.965595][ T1] virtio_dev_probe+0x991/0xaf0
[ 7.966818][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 7.967921][ T1] really_probe+0x29e/0xc50
[ 7.968593][ T1] __driver_probe_device+0x1a2/0x3e0
[ 7.969535][ T1] driver_probe_device+0x50/0x430
[ 7.970634][ T1] __driver_attach+0x45f/0x710
[ 7.971732][ T1] ? __pfx___driver_attach+0x10/0x10
[ 7.973000][ T1] bus_for_each_dev+0x239/0x2b0
[ 7.974208][ T1] ? __pfx___driver_attach+0x10/0x10
[ 7.975425][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 7.976355][ T1] ? do_raw_spin_unlock+0x13c/0x8b0
[ 7.977543][ T1] bus_add_driver+0x347/0x620
[ 7.979682][ T1] driver_register+0x23a/0x320
[ 7.981056][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 7.982342][ T1] virtio_scsi_init+0x65/0xe0
[ 7.983870][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 7.985269][ T1] do_one_initcall+0x238/0x830
[ 7.986554][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 7.987867][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 7.989039][ T1] ? lockdep_hardirqs_on_prepare+0x43d/0x780
[ 7.990465][ T1] ? __pfx_parse_args+0x10/0x10
[ 7.991527][ T1] ? do_initcalls+0x1c/0x80
[ 7.992292][ T1] ? rcu_is_watching+0x15/0xb0
[ 7.993265][ T1] do_initcall_level+0x157/0x210
[ 7.994180][ T1] do_initcalls+0x3f/0x80
[ 7.994906][ T1] kernel_init_freeable+0x435/0x5d0
[ 7.995937][ T1] ? __pfx_kernel_init_freeable+0x10/0x10
[ 7.996856][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 7.997739][ T1] ? __pfx_kernel_init+0x10/0x10
[ 7.999001][ T1] ? __pfx_kernel_init+0x10/0x10
[ 7.999909][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.000823][ T1] kernel_init+0x1d/0x2b0
[ 8.001451][ T1] ret_from_fork+0x4b/0x80
[ 8.002268][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.003408][ T1] ret_from_fork_asm+0x1a/0x30
[ 8.004122][ T1] </TASK>
[ 8.005036][ T1] Kernel panic - not syncing: kernel: panic_on_warn set ...
[ 8.006846][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-syzkaller-09791-ge5eb28f6d1af-dirty #0
[ 8.009117][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
[ 8.011687][ T1] Call Trace:
[ 8.012892][ T1] <TASK>
[ 8.013386][ T1] dump_stack_lvl+0x241/0x360
[ 8.013386][ T1] ? __pfx_dump_stack_lvl+0x10/0x10
[ 8.013386][ T1] ? __pfx__printk+0x10/0x10
[ 8.013386][ T1] ? _printk+0xd5/0x120
[ 8.013386][ T1] ? vscnprintf+0x5d/0x90
[ 8.013386][ T1] panic+0x349/0x860
[ 8.013386][ T1] ? __warn+0x172/0x4b0
[ 8.013386][ T1] ? __pfx_panic+0x10/0x10
[ 8.013386][ T1] ? show_trace_log_lvl+0x4e6/0x520
[ 8.013386][ T1] ? ret_from_fork_asm+0x1a/0x30
[ 8.013386][ T1] __warn+0x31e/0x4b0
[ 8.013386][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.013386][ T1] report_bug+0x2b3/0x500
[ 8.013386][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.013386][ T1] handle_bug+0x3e/0x70
[ 8.013386][ T1] exc_invalid_op+0x1a/0x50
[ 8.013386][ T1] asm_exc_invalid_op+0x1a/0x20
[ 8.013386][ T1] RIP: 0010:refcount_warn_saturate+0xfa/0x1d0
[ 8.013386][ T1] Code: b2 00 00 00 e8 27 5a f7 fc 5b 5d c3 cc cc cc cc e8 1b 5a f7 fc c6 05 f6 81 d3 0a 01 90 48 c7 c7 e0 a7 fd 8b e8 47 2e ba fc 90 <0f> 0b 90 90 eb d9 e8 fb 59 f7 fc c6 05 d3 81 d3 0a 01 90 48 c7 c7
[ 8.013386][ T1] RSP: 0000:ffffc90000066e18 EFLAGS: 00010246
[ 8.013386][ T1] RAX: 427762defa97e000 RBX: ffff888020edeb2c RCX: ffff8880166c8000
[ 8.013386][ T1] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ 8.013386][ T1] RBP: 0000000000000004 R08: ffffffff8157cf32 R09: fffffbfff1bf9650
[ 8.013386][ T1] R10: dffffc0000000000 R11: fffffbfff1bf9650 R12: ffffea0000843dc0
[ 8.013386][ T1] R13: ffffea0000843dc8 R14: 1ffffd40001087b9 R15: 0000000000000000
[ 8.013386][ T1] ? __warn_printk+0x292/0x360
[ 8.013386][ T1] ? refcount_warn_saturate+0xf9/0x1d0
[ 8.013386][ T1] __free_pages_ok+0xc36/0xd60
[ 8.013386][ T1] make_alloc_exact+0xa3/0xf0
[ 8.013386][ T1] vring_alloc_queue_split+0x20a/0x600
[ 8.013386][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 8.013386][ T1] ? vp_find_vqs+0x4c/0x4e0
[ 8.013386][ T1] ? virtscsi_probe+0x3ea/0xf60
[ 8.013386][ T1] ? virtio_dev_probe+0x991/0xaf0
[ 8.013386][ T1] ? really_probe+0x29e/0xc50
[ 8.013386][ T1] ? driver_probe_device+0x50/0x430
[ 8.013386][ T1] vring_create_virtqueue_split+0xc6/0x310
[ 8.013386][ T1] ? ret_from_fork+0x4b/0x80
[ 8.063354][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 8.063354][ T1] vring_create_virtqueue+0xca/0x110
[ 8.063354][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.063354][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.063354][ T1] setup_vq+0xe9/0x2d0
[ 8.063354][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.063354][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.063354][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.063354][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.063354][ T1] vp_setup_vq+0xbf/0x330
[ 8.063354][ T1] ? __pfx_vp_config_changed+0x10/0x10
[ 8.063354][ T1] ? ioread16+0x2f/0x90
[ 8.063354][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.063354][ T1] vp_find_vqs_msix+0x8b2/0xc80
[ 8.063354][ T1] vp_find_vqs+0x4c/0x4e0
[ 8.063354][ T1] virtscsi_init+0x8db/0xd00
[ 8.063354][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 8.063354][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 8.063354][ T1] ? scsi_host_alloc+0xa57/0xea0
[ 8.063354][ T1] ? vp_get+0xfd/0x140
[ 8.063354][ T1] virtscsi_probe+0x3ea/0xf60
[ 8.063354][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 8.063354][ T1] ? virtqueue_dma_mapping_error+0xd/0x80
[ 8.063354][ T1] ? __pfx_vp_set_status+0x10/0x10
[ 8.063354][ T1] ? vp_set_status+0x1a/0x40
[ 8.063354][ T1] ? virtio_no_restricted_mem_acc+0x9/0x10
[ 8.063354][ T1] ? virtio_features_ok+0x10c/0x270
[ 8.063354][ T1] virtio_dev_probe+0x991/0xaf0
[ 8.063354][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 8.063354][ T1] really_probe+0x29e/0xc50
[ 8.063354][ T1] __driver_probe_device+0x1a2/0x3e0
[ 8.063354][ T1] driver_probe_device+0x50/0x430
[ 8.063354][ T1] __driver_attach+0x45f/0x710
[ 8.063354][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.063354][ T1] bus_for_each_dev+0x239/0x2b0
[ 8.063354][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.063354][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 8.063354][ T1] ? do_raw_spin_unlock+0x13c/0x8b0
[ 8.063354][ T1] bus_add_driver+0x347/0x620
[ 8.063354][ T1] driver_register+0x23a/0x320
[ 8.063354][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.063354][ T1] virtio_scsi_init+0x65/0xe0
[ 8.063354][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.063354][ T1] do_one_initcall+0x238/0x830
[ 8.063354][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.063354][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 8.063354][ T1] ? lockdep_hardirqs_on_prepare+0x43d/0x780
[ 8.063354][ T1] ? __pfx_parse_args+0x10/0x10
[ 8.113373][ T1] ? do_initcalls+0x1c/0x80
[ 8.113373][ T1] ? rcu_is_watching+0x15/0xb0
[ 8.113373][ T1] do_initcall_level+0x157/0x210
[ 8.113373][ T1] do_initcalls+0x3f/0x80
[ 8.113373][ T1] kernel_init_freeable+0x435/0x5d0
[ 8.113373][ T1] ? __pfx_kernel_init_freeable+0x10/0x10
[ 8.113373][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.113373][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.113373][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.113373][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.113373][ T1] kernel_init+0x1d/0x2b0
[ 8.113373][ T1] ret_from_fork+0x4b/0x80
[ 8.113373][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.113373][ T1] ret_from_fork_asm+0x1a/0x30
[ 8.113373][ T1] </TASK>
[ 8.113373][ T1] Kernel Offset: disabled
[ 8.113373][ T1] Rebooting in 86400 seconds..


syzkaller build log:
go env (err=<nil>)
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/syzkaller/.cache/go-build'
GOENV='/syzkaller/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/syzkaller/jobs/linux/gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/syzkaller/jobs/linux/gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/syzkaller/jobs/linux/gopath/src/github.com/google/syzkaller/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2569298022=/tmp/go-build -gno-record-gcc-switches'

git status (err=<nil>)
HEAD detached at d615901c7
nothing to commit, working tree clean


tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=d615901c739a765329b688494cee2f8e1b5037cb -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240314-145638'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=d615901c739a765329b688494cee2f8e1b5037cb -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240314-145638'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=d615901c739a765329b688494cee2f8e1b5037cb -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240314-145638'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -Wno-unused-but-set-variable -Wno-unused-command-line-argument -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
-DHOSTGOOS_linux=1 -DGIT_REVISION=\"d615901c739a765329b688494cee2f8e1b5037cb\"


Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=161a7959180000


Tested on:

commit: e5eb28f6 Merge tag 'mm-nonmm-stable-2024-03-14-09-36' ..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
kernel config: https://syzkaller.appspot.com/x/.config?x=839e3be5d86ffd1d
dashboard link: https://syzkaller.appspot.com/bug?extid=f3bc6f8108108010a03d
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=13298231180000