Re: [PATCH] net: dsa: add return value check of genphy_read_status()

[Александра Дюпина]

Hello, Andrew!

The dsa_register_switch() function is used in various DSA
drivers (in probe function), so it is necessary to check all
possible errors. If the return value (may be an error code)
of genphy_read_status() is not checked in
dsa_shared_port_fixed_link_register_of(), a possible error
in dsa_register_switch() may be missed.

14/03/24 16:02, Andrew Lunn пишет:

> On Thu, Mar 14, 2024 at 09:30:08AM +0300, Alexandra Diupina wrote:
> > Need to check return value of genphy_read_status(),
> > because higher in the call hierarchy is the
> > dsa_register_switch() function,
> > which is used in various drivers.
> I don't understand the commit message. Why is it important to
> dsa_register_switch()?
>
> 	Andrew