Re: [PATCH] arm64: dts: qcom: sdm630-nile: add pinctrl for camera key

From: Krzysztof Kozlowski
Date: Fri Mar 15 2024 - 04:33:37 EST


On 15/03/2024 00:23, Sebastian Raase wrote:
>>> gpio-keys {
>>> compatible = "gpio-keys";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&gpio_keys_default>;
>>
>> A nit: Please reverse the order: pinctrl-0 then names
>
> All existing pinctrl definitions use pinctrl-names first, so I followed the existing file. Is this still okay?

No, not all. If you are sending v2, why you cannot fix this in new code?

Best regards,
Krzysztof