Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs_emit

From: Michael Büsch
Date: Thu Mar 14 2024 - 14:33:26 EST


On Thu, 14 Mar 2024 17:48:22 +0800
Li Zhijian <lizhijian@xxxxxxxxxxx> wrote:

> case B43legacy_INTERFMODE_NONE:
> - count = snprintf(buf, PAGE_SIZE, "0 (No Interference"
> - " Mitigation)\n");
> + count = sysfs_emit(buf, "0 (No Interference" " Mitigation)\n");
> break;

> if (wldev->short_preamble)
> - count = snprintf(buf, PAGE_SIZE, "1 (Short Preamble"
> - " enabled)\n");
> + count = sysfs_emit(buf, "1 (Short Preamble" " enabled)\n");
> else
> - count = snprintf(buf, PAGE_SIZE, "0 (Short Preamble"
> - " disabled)\n");
> + count = sysfs_emit(buf, "0 (Short Preamble" " disabled)\n");
>

Please either leave the line break in place, or remove the string continuation.



--
Michael Büsch
https://bues.ch/

Attachment: pgp23pk2Z3WxK.pgp
Description: OpenPGP digital signature