Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS

From: Erwan Velu
Date: Thu Mar 14 2024 - 14:04:35 EST



Le 14/03/2024 à 18:55, Brett Creeley a écrit :
[...]
AFAIK there is no API for a user to change the max_mtu, so the only way
the device's MFS would need to change is if it's done during
initialization time, which should be done before netdev registration anyway.

Sorry Brett, I was probably unclear and please note that I'm not a network developer, just a user that faced a bug.

My initial though was to check the mfs size in i40e_change_mtu() and if mfs is too small, then let's increase it.

Maybe just resetting it at init time to the largest value (which seems to be the default fw behavior) is a best approach.

I'd love to ear from Intel dev that knows this driver/cards/fw better on what's the best approach here.

Erwan,