Re: [PATCH v9 07/27] net: wan: Add support for QMC HDLC

[Christophe Leroy]

Le 14/03/2024 à 16:21, Guenter Roeck a écrit :
> On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:
>> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
>> Multichannel Controller) to transfer the HDLC data.
>>
>> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
>> Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
>> Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>
>> ---
> [ ... ]
> 
>> +
>> +static const struct of_device_id qmc_hdlc_id_table[] = {
>> +	{ .compatible = "fsl,qmc-hdlc" },
>> +	{} /* sentinel */
>> +};
>> +MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
> 
> I am a bit puzzled. How does this even compile ?

Because

#else  /* !MODULE */
#define MODULE_DEVICE_TABLE(type, name)
#endif


We should probably try to catch those errors when CONFIG_MODULE is not set.

By the way, a fix is available at 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240314123346.461350-1-herve.codina@xxxxxxxxxxx/

Christophe