Re: [PATCH net] rds: introduce acquire/release ordering in acquire/release_in_xmit()

[Michal Kubiak]

On Thu, Mar 14, 2024 at 08:21:35PM +0900, Yewon Choi wrote:
> acquire/release_in_xmit() work as bit lock in rds_send_xmit(), so they
> are expected to ensure acquire/release memory ordering semantics.
> However, test_and_set_bit/clear_bit() don't imply such semantics, on
> top of this, following smp_mb__after_atomic() does not guarantee release
> ordering (memory barrier actually should be placed before clear_bit()).
> 
> Instead, we use clear_bit_unlock/test_and_set_bit_lock() here.
> 
> Signed-off-by: Yewon Choi <woni9911@xxxxxxxxx>

Missing "Fixes" tag for the patch addressed to the "net" tree.

Thanks,
Michal