Re: [PATCH 2/3] mm/compaction: add and use for_each_populated_zone_pgdat() helper

From: kernel test robot
Date: Thu Mar 14 2024 - 07:40:39 EST


Hi Luis,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url: https://github.com/intel-lab-lkp/linux/commits/Luis-Chamberlain/mm-show_mem-simplify-ifdef-on-si_meminfo_node/20240314-085917
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240314005436.2962962-3-mcgrof%40kernel.org
patch subject: [PATCH 2/3] mm/compaction: add and use for_each_populated_zone_pgdat() helper
config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240314/202403141931.2XJWI4fa-lkp@xxxxxxxxx/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240314/202403141931.2XJWI4fa-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403141931.2XJWI4fa-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

mm/compaction.c: In function 'fragmentation_score_node':
>> mm/compaction.c:2252:13: warning: unused variable 'zoneid' [-Wunused-variable]
2252 | int zoneid;
| ^~~~~~


vim +/zoneid +2252 mm/compaction.c

2240
2241 /*
2242 * The per-node proactive (background) compaction process is started by its
2243 * corresponding kcompactd thread when the node's fragmentation score
2244 * exceeds the high threshold. The compaction process remains active till
2245 * the node's score falls below the low threshold, or one of the back-off
2246 * conditions is met.
2247 */
2248 static unsigned int fragmentation_score_node(pg_data_t *pgdat)
2249 {
2250 unsigned int score = 0;
2251 struct zone *zone;
> 2252 int zoneid;
2253
2254 for_each_populated_zone_pgdat(zone, pgdat)
2255 score += fragmentation_score_zone_weighted(zone);
2256
2257 return score;
2258 }
2259

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki