Re: [syzbot] [overlayfs?] WARNING in ovl_copy_up_file

From: Miklos Szeredi
Date: Thu Mar 14 2024 - 05:38:55 EST


On Wed, 13 Mar 2024 at 21:55, Amir Goldstein <amir73il@xxxxxxxxx> wrote:

> The WARN_ON that I put in ovl_verify_area() may be too harsh.
> I think they can happen if lower file is changed (i_size) while file is being
> copied up after reading i_size into the copy length and this could be
> the case with this syzbot reproducer that keeps mounting overlayfs
> instances over same path.
>
> Should probably demote those WARN_ON to just returning EIO?

Sounds good.

Thanks,
Miklos