Re: [PATCH] ssb: use "break" on default case to prevent warning
From: Kalle Valo
Date: Thu Mar 14 2024 - 04:56:48 EST
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> Having an empty default: case in a switch statement causes a warning
> (when using Clang; I don't see the warning when using gcc),
> so add a "break;" to the default case to prevent the warning:
>
> drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]
>
> Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@xxxxxxxxx/
> Cc: Michael Büsch <m@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: llvm@xxxxxxxxxxxxxxx
> Acked-by: Michael Büsch <m@xxxxxxx>
> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Patch applied to wireless-next.git, thanks.
6c700b35a534 ssb: use "break" on default case to prevent warning
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240313001305.18820-1-rdunlap@xxxxxxxxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches