Re: [PATCH v2] spi: Fix error code checking in spi_mem_exec_op()

[Miquel Raynal]

Hi Florian,

florian.fainelli@xxxxxxxxxxxx wrote on Wed, 13 Mar 2024 12:45:30 -0700:

> After commit cff49d58f57e ("spi: Unify error codes by replacing -ENOTSUPP with
> -EOPNOTSUPP"), our SPI NOR flashes would stop probing with the following
> visible in the kernel log:
> 
> [    2.196300] brcmstb_qspi f0440920.qspi: using bspi-mspi mode
> [    2.210295] spi-nor: probe of spi1.0 failed with error -95
> 
> It turns out that the check in spi_mem_exec_op() was changed to check
> for -ENOTSUPP (old error code) or -EOPNOTSUPP (new error code), but this
> means that for drivers that were converted, the second condition is now
> true, and we stop falling through like we used to. Fix the error to
> check for neither error being neither -ENOTSUPP *nor* -EOPNOTSUPP.
> 
> Fixes: cff49d58f57e ("spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP")
> Reviewed-by: Michael Walle <mwalle@xxxxxxxxxx>
> Reviewed-by: Pratyush Yadav <pratyush@xxxxxxxxxx>
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

Thanks for the fix!

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>