Re: [PATCH] nvme-multipath: fix bogus request queue reference put

From: mengfanhui
Date: Thu Mar 14 2024 - 02:14:05 EST


Purpose that to check if we ever added a live path (using
NVME_NS_HEAD_HAS_DISK flag) and if not, clear the disk->queue
reference.The purpose is to perform security checks and remove the disk.


在 2024/1/17 22:39, Christoph Hellwig 写道:
> On Wed, Jan 17, 2024 at 04:04:12PM +0200, Sagi Grimberg wrote:
>> How did you see this? disk->queue is allocated in blk_alloc_disk called
>> in nvme_mpath_alloc_disk... I don't understand how you saw the same
>> dereference that was addressed by this commit.
>
> This looks like a backport of an old patch of yours to a geriatric
> kernel to me..