RE: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences

[Ronnie.Kunin]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Wednesday, March 13, 2024 3:53 PM
> To: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: Ronnie Kunin - C21729 <Ronnie.Kunin@xxxxxxxxxxxxx>; Raju Lakkaraju - I30499
> <Raju.Lakkaraju@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Bryan Whitehead - C21958 <Bryan.Whitehead@xxxxxxxxxxxxx>;
> richardcochran@xxxxxxxxx; UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>
> Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration
> sequences
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> So i think we need to agree on best practices for new drivers and document what that is, probably in
> both the ethtool man page and include/uapi/linux/ethtool.h
> 
> * WAKE_MAGIC on its own is O.K.
> * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL
> * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL.
> * Each driver needs to enforce this, due to backwards compatibility.
>   Some may decide not to.
> 
> Can we agree on this?

Sounds good to me.
Raju (and other MCHP folks) are out this week due to a company shutdown, but he should be able to submit a new patch for lan743x as described above when back next week.

> 
>     Andrew