Re: [PATCH 2/2] arm64: dts: mediatek: Add missing chassis-type to MT8192 Chromebooks

[David Heidelberg]

Optional, but very useful for some user-space decisions. Thank you.

Reviewed-by: David Heidelberg <david@xxxxxxx>

On 13/03/2024 15:15, AngeloGioacchino Del Regno wrote:
> None of the MT8192 Chromebooks had their chassis-type specified: add
> the right definition for each.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts      | 1 +
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts | 1 +
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts    | 1 +
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts    | 1 +
>   4 files changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> index fd2cb8765a15..ac2673e56fb8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> @@ -7,6 +7,7 @@
>   
>   / {
>   	model = "Google Hayato rev1";
> +	chassis-type = "convertible";
>   	compatible = "google,hayato-rev1", "google,hayato", "mediatek,mt8192";
>   };
>   
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> index 3127ee5f6172..cd86ad9ba28a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> @@ -7,6 +7,7 @@
>   
>   / {
>   	model = "Google Hayato rev5";
> +	chassis-type = "convertible";
>   	compatible = "google,hayato-rev5-sku2", "google,hayato-sku2",
>   		     "google,hayato", "mediatek,mt8192";
>   };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> index bc88866ab2f5..29aa87e93888 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> @@ -8,6 +8,7 @@
>   
>   / {
>   	model = "Google Spherion (rev0 - 3)";
> +	chassis-type = "laptop";
>   	compatible = "google,spherion-rev3", "google,spherion-rev2",
>   		     "google,spherion-rev1", "google,spherion-rev0",
>   		     "google,spherion", "mediatek,mt8192";
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> index 0039158c9e60..5e9e598bab90 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> @@ -8,6 +8,7 @@
>   
>   / {
>   	model = "Google Spherion (rev4)";
> +	chassis-type = "laptop";
>   	compatible = "google,spherion-rev4", "google,spherion",
>   		     "mediatek,mt8192";
>   

--
David Heidelberg