Re: [PATCH bpf-next 1/3] uprobes: encapsulate preparation of uprobe args buffer

[Andrii Nakryiko]

On Wed, Mar 13, 2024 at 8:16 AM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> LGTM, one nit below.
>
> On 03/12, Andrii Nakryiko wrote:
> >
> > +static struct uprobe_cpu_buffer *prepare_uprobe_buffer(struct trace_uprobe *tu,
> > +                                                    struct pt_regs *regs)
> > +{
> > +     struct uprobe_cpu_buffer *ucb;
> > +     int dsize, esize;
> > +
> > +     esize = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
> > +     dsize = __get_data_size(&tu->tp, regs);
> > +
> > +     ucb = uprobe_buffer_get();
> > +     ucb->dsize = dsize;
> > +
> > +     store_trace_args(ucb->buf, &tu->tp, regs, esize, dsize);
> > +
> > +     return ucb;
> > +}
>
> OK, but note that every user of ->dsize adds tp.size. So I think you can
> simplify this code a bit more if you change prepare_uprobe_buffer() to do
>
>         ucb->dsize = tu->tp.size + dsize;
>
> and update the users.
>

makes sense, done

> Oleg.
>