Re: [PATCH v2 08/13] selftests/resctrl: Add ->init() callback into resctrl_val_param

From: Maciej Wieczor-Retman
Date: Wed Mar 13 2024 - 06:16:10 EST


Hi,

On 2024-03-11 at 15:52:25 +0200, Ilpo Järvinen wrote:
>diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
>index 241c0b129b58..e79eca9346f3 100644
>--- a/tools/testing/selftests/resctrl/cmt_test.c
>+++ b/tools/testing/selftests/resctrl/cmt_test.c
>@@ -16,6 +16,17 @@
> #define MAX_DIFF 2000000
> #define MAX_DIFF_PERCENT 15
>
>+#define CON_MON_LCC_OCCUP_PATH \
>+ "%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/llc_occupancy"
>+
>+static int set_cmt_path(const struct resctrl_val_param *param, int domain_id)
>+{
>+ sprintf(llc_occup_path, CON_MON_LCC_OCCUP_PATH, RESCTRL_PATH,
>+ param->ctrlgrp, param->mongrp, domain_id);
>+
>+ return 0;
>+}
>+

Is there an option to make this function (and the set_mbm_path()) global through
the resctrl.h?

I'd like to use it in my SNC series [1] for looping over different nodes and
that requires changing the paths during the measure phase of the tests and that
part is currently in cache.c:measure_llc_resctrl().

Or would you suggest some other way of changing these paths in cache?

--
Kind regards
Maciej Wieczór-Retman