Re: [PATCH] fat: ignore .. subdir and always add a link to dirs

From: OGAWA Hirofumi
Date: Wed Mar 13 2024 - 04:06:00 EST


Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxx> writes:

>> You are forgetting to count about normal dirs other than "." and ".."?
>>
>
> Yes, I was not counting those. The patch simply ignores ".." when counting dirs
> (which is used only for determining the number of links), and always adds one
> link. Then, when validating the inode, it also only requires that at least one
> link exists instead of two.

So you break the mkdir/rmdir link counting, isn't it?

Thanks.

> There is only one other instance of fat_subdirs being called and that's when
> the root dir link count is determined. I left that one unchanged, as usually
> "." and ".." does not exist there and we always add two links there.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>