Re: [v1] staging: media: starfive: Clean pad selection in isp_try_format()

From: Dan Carpenter
Date: Wed Mar 13 2024 - 02:01:40 EST


On Mon, Mar 11, 2024 at 07:45:20PM -0700, Changhuang Liang wrote:
> The code to select isp_dev->formats[] is overly complicated. We can
> just use the "pad" as the index. This will making adding new pads
> easier in future patches. No functional change.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---

I'm not sure that patchwork will find this patch if it doesn't have
[PATCH] in the subject... But otherwise the patch looks good. Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter