Re: [PATCH 2/3] arm64: dts: qcom: sm8650: add support for the SM8650-HDK board

From: Dmitry Baryshkov
Date: Tue Mar 12 2024 - 16:00:00 EST


On Tue, 12 Mar 2024 at 20:45, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
>
> On 03/03/2024 00:26, Vladimir Zapolskiy wrote:
> > Hi Neil,
> >
> > On 2/23/24 10:52, Neil Armstrong wrote:
> >> The SM8650-HDK is an embedded development platforms for the
> >> Snapdragon 8 Gen 3 SoC aka SM8650, with the following features:
> >> - Qualcomm SM8650 SoC
> >> - 16GiB On-board LPDDR5
> >> - On-board WiFi 7 + Bluetooth 5.3/BLE
> >> - On-board UFS4.0
> >> - M.2 Key B+M Gen3x2 PCIe Slot
> >> - HDMI Output
> >> - USB-C Connector with DP Almode & Audio Accessory mode
> >> - Micro-SDCard Slot
> >> - Audio Jack with Playback and Microphone
> >> - 2 On-board Analog microphones
> >> - 2 On-board Speakers
> >> - 96Boards Compatible Low-Speed and High-Speed connectors [1]
> >> - For Camera, Sensors and external Display cards
> >> - Compatible with the Linaro Debug board [2]
> >
> > what are these [1] and [2] references? Probably there might be some links.
>
> Indeed
>
> >
> >> - SIM Slot for Modem
> >> - Debug connectors
> >> - 6x On-Board LEDs
> >>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> >> ---
> >> arch/arm64/boot/dts/qcom/Makefile | 1 +
> >> arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 1259 +++++++++++++++++++++++++++++++
> >> 2 files changed, 1260 insertions(+)


> >
> >> +&pcie_1_phy_aux_clk {
> >> + clock-frequency = <1000>;
> >> +};
> >> +
> >
> > May be put the clock above after &pcie1_phy like in the list of gcc
> > source clocks?
>
> Ack

IIUC, this is not the actual frequency of the clock.


--
With best wishes
Dmitry