Re: [PATCH v3] clocksource: timer-riscv: Clear timer interrupt on timer initialization

[Atish Kumar Patra]

On Tue, Mar 12, 2024 at 10:40 AM Samuel Holland
<samuel.holland@xxxxxxxxxx> wrote:
>
> On 2024-03-06 11:23 AM, Ley Foon Tan wrote:
> > In the RISC-V specification, the stimecmp register doesn't have a default
> > value. To prevent the timer interrupt from being triggered during timer
> > initialization, clear the timer interrupt by writing stimecmp with a
> > maximum value.
> >
> > Fixes: 9f7a8ff6391f ("RISC-V: Prefer sstc extension if available")
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> >
> > ---
> > v3:
> > Resolved comment from Samuel Holland.
> > - Function riscv_clock_event_stop() needs to be called before
> >   clockevents_config_and_register(), move riscv_clock_event_stop().
> >
> > v2:
> > Resolved comments from Anup.
> > - Moved riscv_clock_event_stop() to riscv_timer_starting_cpu().
> > - Added Fixes tag
> > ---
> >  drivers/clocksource/timer-riscv.c | 3 +++
> >  1 file changed, 3 insertions(+)
>
> Reviewed-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
> Tested-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
>

Reviewed-by: Atish Patra <atishp@xxxxxxxxxxxx>