Re: [PATCH v7 0/5] PCI/ASPM: Save/restore L1 PM Substates for suspend/resume

[tasev.stefanoska]

Le 7/03/24 à 23:25, Bjorn Helgaas a écrit :

> [+cc Koba Ko]
>
> On Tue, Mar 05, 2024 at 03:46:56PM -0600, Bjorn Helgaas wrote:
> > On Fri, Feb 23, 2024 at 02:58:46PM -0600, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > >
> > > This is some rework of David's series to preserve ASPM L1 substate
> > > configuration across suspend/resume.
> > > ...
> > > David E. Box (5):
> > >    PCI/ASPM: Move pci_configure_ltr() to aspm.c
> > >    PCI/ASPM: Always build aspm.c
> > >    PCI/ASPM: Move pci_save_ltr_state() to aspm.c
> > >    PCI/ASPM: Save L1 PM Substates Capability for suspend/resume
> > >    PCI/ASPM: Call pci_save_ltr_state() from pci_save_pcie_state()
> > >
> > >   drivers/pci/pci.c         |  89 ++++------------
> > >   drivers/pci/pci.h         |  13 ++-
> > >   drivers/pci/pcie/Makefile |   2 +-
> > >   drivers/pci/pcie/aspm.c   | 215 ++++++++++++++++++++++++++++++++++++++
> > >   drivers/pci/probe.c       |  62 +----------
> > >   include/linux/pci.h       |   2 +-
> > >   6 files changed, 252 insertions(+), 131 deletions(-)
> > I applied these as pci/aspm for v6.9, replacing the original unlabeled
> > v6 that has been in -next.
> Would anybody be able to test this, particularly to make sure it works
> for the bugs we're claiming to fix with this series?
>
>    https://bugzilla.kernel.org/show_bug.cgi?id=217321
>    https://bugzilla.kernel.org/show_bug.cgi?id=216782
>    https://bugzilla.kernel.org/show_bug.cgi?id=216877
>
> This series is headed for v6.9, and I hope we can finally claim
> victory over these issues.
>
> This is in -next as of the Mar 7 tree.  Or if you want just the ASPM
> changes, based on v6.8-rc1, you can use the branch at
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=aspm
>
> Bjorn

I just tested the patch v7 from Bjorn, it works on my Asus UX305FA.
Tested on kernel v6.8-rc1.

Tasev