Re: [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

[Konrad Dybcio]

On 2/23/24 23:48, Trilok Soni wrote:
> On 2/23/2024 1:21 PM, Konrad Dybcio wrote:
> > +	/* Wait 50us for PLL_LOCK_DET bit to go high */
> > +	usleep_range(50, 55);
> > +
> > +	/* Enable PLL output */
> > +	regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, PLL_OUTCTRL);
> > +}
> > +EXPORT_SYMBOL(clk_huayra_2290_pll_configure);
>
> Please use EXPORT_SYMBOL_GPL.

Sure, I glanced over this!

I've also noticed that it's a very common oversight.. would you be
interested in extending scripts/checkpatch.pl to suggest the _GPL
variant?

Konrad