Re: [v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent()

From: Kalle Valo
Date: Tue Mar 12 2024 - 11:31:41 EST


Rand Deeb <rand.sec96@xxxxxxxxx> wrote:

> The ssb_device_uevent() function first attempts to convert the 'dev' pointer
> to 'struct ssb_device *'. However, it mistakenly dereferences 'dev' before
> performing the NULL check, potentially leading to a NULL pointer
> dereference if 'dev' is NULL.
>
> To fix this issue, move the NULL check before dereferencing the 'dev' pointer,
> ensuring that the pointer is valid before attempting to use it.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Rand Deeb <rand.sec96@xxxxxxxxx>

Patch applied to wireless-next.git, thanks.

789c17185fb0 ssb: Fix potential NULL pointer dereference in ssb_device_uevent()

--
https://patchwork.kernel.org/project/linux-wireless/patch/20240306123028.164155-1-rand.sec96@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches