Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware

[Geert Uytterhoeven]

On Tue, Mar 12, 2024 at 3:41 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Wed, Feb 21, 2024 at 3:06 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> > On Fri, Feb 16, 2024 at 11:08 PM Saurabh Singh Sengar
> > <ssengar@xxxxxxxxxxxxxxxxxxx> wrote:
> > > This adds the strict check for compatible which makes compatible
> > > to be mandatory for root nodes. So far, DeviceTree without compatible
> > > property in root nodes can work. Do we want to make this documented
> > > somewhere ?
> >
> > It already is in the DT spec and schemas.
>
> How many systems in the wild violate this?
>
> Apparently the DTS generated by LiteX does not have a root compatible
> (and model) property, hence of_have_populated_dt() returns false.
> While my gateware and DTS is quite old, a quick look at recent
> litex_json2dts_linux.py history shows this is still true for current LiteX.

https://github.com/enjoy-digital/litex/issues/1905

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds