Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

[Alexandre Mergnat]

On 26/02/2024 16:25, AngeloGioacchino Del Regno wrote:
> > +    if (enable) {
> > +        /* set gpio mosi mode */
> > +        regmap_write(priv->regmap, MT6357_GPIO_MODE2_CLR, 
> > GPIO_MODE2_CLEAR_ALL);
> > +        regmap_write(priv->regmap, MT6357_GPIO_MODE2_SET, 
> > GPIO8_MODE_SET_AUD_CLK_MOSI |
> > +                                  GPIO9_MODE_SET_AUD_DAT_MOSI0 |
> > +                                  GPIO10_MODE_SET_AUD_DAT_MOSI1 |
> > +                                  GPIO11_MODE_SET_AUD_SYNC_MOSI);
>
> Are you sure that you need to write to MODE2_SET *and* to MODE2?!

This is downstream code and these registers aren't in my documentation.
I've removed the MODE2_SET write and test the audio: it's still working.

So I will keep the spurious write removed for v2. :)

--
Regards,
Alexandre