Re: [PATCH 4/4] iomap: cleanup iomap_write_iter()

From: Christoph Hellwig
Date: Tue Mar 12 2024 - 08:24:15 EST


On Mon, Mar 11, 2024 at 09:07:39AM -0700, Darrick J. Wong wrote:
> If at some point iomap_write_end actually starts returning partial write
> completions (e.g. you wrote 250 bytes, but for some reason the pagecache
> only acknowledges 100 bytes were written) then this code no longer
> reverts the iter or truncates posteof pagecache correctly...

I don't think it makes sense to return a partial write from
iomap_write_end. But to make that clear it really should not return
a byte count by a boolean. I've been wanting to make that cleanup
for a while, but it would reach all the way into buffer.c.