Re: [PATCH] gpio: nomadik: remove BUG_ON() in nmk_gpio_populate_chip()

From: Bartosz Golaszewski
Date: Tue Mar 12 2024 - 08:14:59 EST


On Tue, Mar 12, 2024 at 12:52 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Mon, Mar 11, 2024 at 12:00 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> > Using BUG_ON() is discouraged and also the check wasn't done early
> > enough to prevent an out of bounds access. Check earlier and return
> > an error instead of calling BUG().
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Thanks Dan, I applied the patch to the pin control tree since the
> rest of the stuff is resting there and Bartosz already sent his pull
> request.
>

Yes I did. There were no conflicts in next with nomadik updates so I
figured you'll just send it yourself. Let me know if you need anything
from my side.

Bart