Re: [PATCH v4 2/4] platform: Add ARM64 platform directory

From: Ilpo Järvinen
Date: Tue Mar 12 2024 - 07:45:42 EST


On Tue, 12 Mar 2024, Bryan O'Donoghue wrote:

> On 12/03/2024 08:42, Nikita Travkin wrote:
> > Some ARM64 based laptops and computers require vendor/board specific
> > drivers for their embedded controllers. Even though usually the most
> > important functionality of those devices is implemented inside ACPI,
> > unfortunately Linux doesn't currently have great support for ACPI on
> > platforms like Qualcomm Snapdragon that are used in most ARM64 laptops
> > today. Instead Linux relies on Device Tree for Qualcomm based devices
> > and it's significantly easier to reimplement the EC functionality in
> > a dedicated driver than to make use of ACPI code.
> >
> > This commit introduces a new platform/arm64 subdirectory to give a
> > place to such drivers for EC-like devices.
> >
> > A new MAINTAINERS entry is added for this directory. Patches to files in
> > this directory will be taken up by the platform-drivers-x86 team (i.e.
> > Hans de Goede and Mark Gross).
> >
> > Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
> > ---
> > MAINTAINERS | 9 +++++++++
> > drivers/platform/Kconfig | 2 ++
> > drivers/platform/Makefile | 1 +
> > drivers/platform/arm64/Kconfig | 19 +++++++++++++++++++
> > drivers/platform/arm64/Makefile | 6 ++++++
> > 5 files changed, 37 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b43102ca365d..ec8d706a99aa 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3050,6 +3050,15 @@ F: drivers/mmc/host/sdhci-of-arasan.c
> > N: zynq
> > N: xilinx
> > +ARM64 PLATFORM DRIVERS
> > +M: Hans de Goede <hdegoede@xxxxxxxxxx>
> > +M: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > +L: platform-driver-x86@xxxxxxxxxxxxxxx
> > +S: Maintained
> > +Q: https://patchwork.kernel.org/project/platform-driver-x86/list/
> > +T: git
> > git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>
> Surely some sort of Arm specific mailing list should be added here ?
> platform-drivers-x86 for arm64 platform drivers standalone, makes little
> sense.
>
> Perhaps for each new SoC class added - you could add the appropriate mailing
> list linux-arm-msm is suspiciously missing from the list even though the only
> driver that will live in this directory after this series is a qcom based
> device.
>
> And if tomorrow someone added a Rockchip based EC controller then you'd assume
> the rockchip mailing list should get a ping.

While generic arm mailing list is perhaps lacking too, for specific
driver related lists it is better to add separate MAINTAINERS entries for
the particular driver and put L: there.

--
i.