Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool()

From: Yosry Ahmed
Date: Tue Mar 12 2024 - 06:22:56 EST


On Tue, Mar 12, 2024 at 2:35 AM Nhat Pham <nphamcs@xxxxxxxxx> wrote:
>
> On Tue, Mar 12, 2024 at 6:52 AM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
> >
> > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true.
> > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a
> > config option and never made it upstream. Remove the unnecessary check.
>
> Do we need a Fixes: tag for this? I guess it's not a bug hmmm.

The compiler should be producing the exact same code either way, so I
would say no. It's just a cleanup.

>
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
>
> Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx>

Thanks!