RE: [EXT] Re: [PATCH v7 06/11] dt-bindings: usb: ci-hdrc-usb2-imx: add compatible and clock-names restriction for imx93

[Xu Yang]

> 
> On 28/02/2024 12:29, Xu Yang wrote:
> > The i.MX93 needs a wakup clock to work properly. This will add compatible
> > and restriction for i.MX93 platform.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> >
> > ---
> > Changes in v2:
> >  - no changes
> > Changes in v3:
> >  - add clocks restriction
> > Changes in v4:
> >  - use 'contains' rather 'items'
> > Changes in v5:
> >  - rename clock name
> > Changes in v6:
> >  - new patch based on ci-hdrc-usb2-imx.yaml
> > Changes in v7:
> >  - no changes
> > ---
> >  .../bindings/usb/ci-hdrc-usb2-imx.yaml        | 34 ++++++++++++++-----
> >  1 file changed, 26 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> > index a4730a2393e6..a2932af2c09b 100644
> > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> > @@ -40,6 +40,7 @@ properties:
> >            - enum:
> >                - fsl,imx8mm-usb
> >                - fsl,imx8mn-usb
> > +              - fsl,imx93-usb
> >            - const: fsl,imx7d-usb
> >            - const: fsl,imx27-usb
> >        - items:
> > @@ -186,14 +187,31 @@ allOf:
> >                - const: ahb
> >                - const: per
> >        else:
> > -        # other imx Socs only need one clock
> > -        properties:
> > -          clocks:
> > -            minItems: 1
> > -            maxItems: 1
> > -          clock-names:
> > -            minItems: 1
> > -            maxItems: 1
> 
> Just make the list explicit in the first place. Don't add lines in one
> patch which is immediately fixed/dropped/replaced.

Okay.

> 
> > +        # imx93 Soc needs two clocks
> > +        if:
> 
> No, no. No if:else:if:else:if:else. Unreadable and unmaintainable.

Okay.  I'll rewrite it.

Thanks,
Xu Yang

> 
> 
> Best regards,
> Krzysztof