Re: [PATCH 2/2] mm: zpool: return pool size in pages

[Yosry Ahmed]

On Mon, Mar 11, 2024 at 10:36:37PM -0400, Johannes Weiner wrote:
> On Mon, Mar 11, 2024 at 10:12:02PM +0000, Yosry Ahmed wrote:
> > On Mon, Mar 11, 2024 at 12:12:14PM -0400, Johannes Weiner wrote:
> > > All zswap backends track their pool sizes in pages. Currently they
> > > multiply by PAGE_SIZE for zswap, only for zswap to divide again in
> > > order to do limit math. Report pages directly.
> > 
> > Nice. Although I would prefer renaming the zpool interface to
> > total_pages and renaming the zpool backends functions as well to use
> > pages rather than size.
> 
> Ha, I was on the fence, since it's kind of churny. But if you don't
> mind, then it works for me as well.

If we are cleaning up, might as well do it all the way :)

> 
> > Either way:
> > Acked-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
> 
> Thanks.

LGTM. Feel free to carry the Ack forward.