Re: [PATCH net-next v11 4/9] dt-bindings: net: convert hisi-femac.txt to YAML

[Yang Xiwen]

On 3/12/2024 12:03 AM, Jakub Kicinski wrote:
> On Sat, 9 Mar 2024 20:30:21 +0800 Yang Xiwen wrote:
> > > +  clock-names:
> > > +    items:
> > > +      - const: mac
> > > +      - const: macif
> > > +      - const: phy
> > Still not very correct here. In downstream the core can also have an
> > external PHY. The internal phy is also optional. So maybe this clock
> > should be optional.
> You are responding to yourself 4 min after posting?
> What is the purpose of your comments?


Just to remind others or myself this can be improved. But i think it's 
ready to be applied. There won't be similar design in mainline soon i think.



--
Regards,
Yang Xiwen