Re: [net-next PATCH v3] octeontx2-pf: Reset MAC stats during probe

[Jakub Kicinski]

On Fri, 8 Mar 2024 23:45:44 +0530 Sai Krishna wrote:
> @@ -3048,6 +3065,9 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  
>  	otx2_qos_init(pf, qos_txqs);
>  
> +	/* reset CGX/RPM MAC stats */
> +	otx2_reset_mac_stats(pf);
> +
>  	return 0;

Looks suspicious, all sort of resets should be usually done before the
netdev / devlink instances are registered. As soon as you register those
they may get brought up and used (including synchronously by an
in-kernel user).
-- 
pw-bot: cr