Re: [PATCH] i2c: muxes: pca954x: Allow sharing reset GPIO

From: Chris Packham
Date: Mon Mar 11 2024 - 16:08:05 EST



On 11/03/24 19:25, Krzysztof Kozlowski wrote:
> On 11/03/2024 05:14, Chris Packham wrote:
>> Some hardware designs with multiple PCA954x devices use a reset GPIO
>> connected to all the muxes. Support this configuration by making use of
>> the reset controller framework which can deal with the shared reset
>> GPIOs. Fall back to the old GPIO descriptor method if the reset
>> controller framework is not enabled.
>>
>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>> ---
>>
>> Notes:
>> This patch goes on top of Krzysztof's series adding the GPIO based reset
>> controller[1] which will be in linux-6.9. With this I'm able to
>> correctly describe my hardware platform in the DTS and have the resets
>> appropriately controlled.
>>
>> [1] - https://lore.kernel.org/all/20240129115216.96479-1-krzysztof.kozlowski@xxxxxxxxxx/
>>
> Where is the changelog? It was v3 or v4 already? Where are the tags?

Since this was spun off the original series I figured it would be best
to treat it as v1 of a new series. It's unchanged since
https://lore.kernel.org/lkml/20240112163608.528453-6-krzysztof.kozlowski@xxxxxxxxxx/
so technically this is '[PATCH resend v3]'. I did rebase it on top of
linux-next just to make sure it still worked.

> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
Oops my bad. I think because by the time v3 rolled round it was part of
your series I never added the Ack from Peter or your R-by to my local
commit which is what I sent out. I've added it now if I send a v4 (or is
it v2 of this?) I'll include the tags.