Re: [PATCH v1] perf lock contention: skip traceiter functions

From: Arnaldo Carvalho de Melo
Date: Mon Mar 11 2024 - 15:53:15 EST


On Mon, Mar 11, 2024 at 07:25:16PM +0000, Anne Macedo wrote:
> Anne Macedo <retpolanne@xxxxxxxxxx> writes:
> > Namhyung Kim <namhyung@xxxxxxxxxx> writes:
> >> I think it depends on the kernel version and configuration. I remember
> >> I saw a different symbol on old kernels. But it'd be hard to handle all
> >> the cases. Let's have a single trace text section in the struct machine
> >> and use __traceiter_contention_begin only. If it's not found you can
> >> fallback to trace_contention_begin.

> However, if we fallback to trace_contention_begin, we won't be able to
> filter out both __traceiter_contention_begin and trace_contention_begin
> at the same time.

I think for ARM we need to skip both, no? I.e. I agree with Anne.

- Arnaldo