Re: [BUG net-next] fcnal-test.sh: 4 (four) tests FAIL

From: David Ahern
Date: Mon Mar 11 2024 - 12:30:37 EST


On 3/11/24 10:17 AM, Jakub Kicinski wrote:
> On Sat, 9 Mar 2024 19:45:15 +0100 Mirsad Todorovac wrote:
>> In the vanilla net-next tree build of v6.8-rc7-2348-g75c2946db360, with up-to-date
>> iproute2 built tools, fcnal-test.sh reports certain failures:
>>
>> --------------------------------------------------------------------------------------
>> # TEST: ping local, VRF bind - VRF IP [FAIL]
>> # TEST: ping local, device bind - ns-A IP [FAIL]
>> # TEST: ping local, VRF bind - VRF IP [FAIL]
>> # TEST: ping local, device bind - ns-A IP [FAIL]
>> --------------------------------------------------------------------------------------
>
> Adding David A to CC.
>
> It rings a bell. We also build ping from source when running the tests
> locally, I have in my notes "AWS iputils are buggy, use iputils.git"
> but unfortunately I didn't make a note which tests were failing without
> it. David might remember..

yes, please update ping -- make sure it has proper support for
SO_BINDTODEVICE.

It's a bug in versions of iputils ping. It sets the BINDTODEVICE and
then resets it because the source address is not set on the command line
(it should not be required - they are separate intents).