Re: [PATCH net-next v3 4/4] net: gro: move L3 flush checks to tcp_gro_receive

From: Richard Gobert
Date: Mon Mar 11 2024 - 05:22:00 EST


Willem de Bruijn wrote:
> Richard Gobert wrote:
>> {inet,ipv6}_gro_receive functions perform flush checks (ttl, flags,
>> iph->id, ...) against all packets in a loop. These flush checks are
>> relevant only to tcp flows, and as such they're used to determine whether
>> the packets can be merged later in tcp_gro_receive.
>>
>> These checks are not relevant to UDP packets.
>
> These are network protocol coalescing invariants. Why would they be
> limited to certain transport protocols only?

Thanks for the review, I'll fix the typos.
I replied to Eric's comment about the relevancy of these checks for UDP.