Re: [PATCH 05/13] sched/balancing: Rename load_balance() => sched_balance_rq()

From: Shrikanth Hegde
Date: Mon Mar 11 2024 - 04:17:57 EST




On 3/8/24 4:48 PM, Ingo Molnar wrote:
> Standardize scheduler load-balancing function names on the
> sched_balance_() prefix.
>
> Also load_balance() has become somewhat of a misnomer: historically
> it was the first and primary load-balancing function that was called,
> but with the introduction of sched domains, it's become a lower
> layer function that balances runqueues.
>
> Rename it to sched_balance_rq() accordingly.

nit: Can this be sched_balance_rqs()? since load balancing happens
between two runqeueus.


> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Shrikanth Hegde <sshegde@xxxxxxxxxxxxx>
> Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> ---

Though one would have been familiar with names(for someone started recently),
given the correct behaviour and historical context helps why the name changes are making sense.

Reviewed-by: Shrikanth Hegde <sshegde@xxxxxxxxxxxxx>