Re: [PATCH v4] dt-bindings: imx-pata: Convert to dtschema

From: Krzysztof Kozlowski
Date: Sun Mar 10 2024 - 03:51:42 EST


On 10/03/2024 06:19, Animesh Agarwal wrote:
> Convert the imx-pata bindings to DT schema.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
>
> ---
> Changes in v4:
> - added fsl,imx31-pata in compatible property
> - imx51-pata was not defined as compatible in txt bindings, adding imx51-pata ensures this node compiles to imx31.dtsi
> Changes in v3:
> - added fsl,imx51-pata in compatible property
> - imx51-pata was not defined as compatible in txt bindings, adding imx51-pata ensures this node compiles to imx51.dtsi
> Changes in v2:
> - fixed style issues
> - compatible property now matches the examples
> - fixed yamllint warnings/errors
> ---
> ---
> .../devicetree/bindings/ata/fsl,imx-pata.yaml | 41 +++++++++++++++++++
> .../devicetree/bindings/ata/imx-pata.txt | 16 --------
> 2 files changed, 41 insertions(+), 16 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
> delete mode 100644 Documentation/devicetree/bindings/ata/imx-pata.txt
>
> diff --git a/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
> new file mode 100644
> index 000000000000..aa0174844eb1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/fsl,imx-pata.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/fsl,imx-pata.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX PATA Controller
> +
> +maintainers:
> + - Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - fsl,imx31-pata
> + - fsl,imx51-pata
> + - const: fsl,imx27-pata
> +

How did you resolve my comment about imx27?

Best regards,
Krzysztof