Re: [PATCH 1/5] dt-bindings: i2c: renesas,riic: Update comment for fallback string

From: Krzysztof Kozlowski
Date: Sat Mar 09 2024 - 06:58:57 EST


On 08/03/2024 18:27, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> With the fallback string being utilized by multiple other SoCs, this
> patch updates the comment for the generic compatible string.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>

Really, you review a comment change? Internally?

Is this some sort of company policy? Are these even true reviews?

> ---
> Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> index 2291a7cd619b..63ac5fe3208d 100644
> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> @@ -22,7 +22,7 @@ properties:
> - renesas,riic-r9a07g043 # RZ/G2UL and RZ/Five
> - renesas,riic-r9a07g044 # RZ/G2{L,LC}
> - renesas,riic-r9a07g054 # RZ/V2L
> - - const: renesas,riic-rz # RZ/A or RZ/G2L
> + - const: renesas,riic-rz # generic RIIC compatible

Just drop the comment instead.

Best regards,
Krzysztof