Re: [PATCH 1/5] media: imx335: Support 2 or 4 lane operation modes
From: kernel test robot
Date: Fri Mar 08 2024 - 13:45:14 EST
Hi Umang,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linuxtv-media-stage/master]
[cannot apply to media-tree/master sailus-media-tree/streams linus/master v6.8-rc7 next-20240308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Umang-Jain/media-imx335-Support-2-or-4-lane-operation-modes/20240306-161903
base: https://git.linuxtv.org/media_stage.git master
patch link: https://lore.kernel.org/r/20240306081038.212412-2-umang.jain%40ideasonboard.com
patch subject: [PATCH 1/5] media: imx335: Support 2 or 4 lane operation modes
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20240309/202403090232.FqnIE4cy-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240309/202403090232.FqnIE4cy-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403090232.FqnIE4cy-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/media/i2c/imx335.c:181: warning: Function parameter or struct member 'lane_mode' not described in 'imx335'
vim +181 drivers/media/i2c/imx335.c
45d19b5fb9aeab Martina Krasteva 2021-05-27 133
45d19b5fb9aeab Martina Krasteva 2021-05-27 134 /**
45d19b5fb9aeab Martina Krasteva 2021-05-27 135 * struct imx335 - imx335 sensor device structure
45d19b5fb9aeab Martina Krasteva 2021-05-27 136 * @dev: Pointer to generic device
45d19b5fb9aeab Martina Krasteva 2021-05-27 137 * @client: Pointer to i2c client
45d19b5fb9aeab Martina Krasteva 2021-05-27 138 * @sd: V4L2 sub-device
45d19b5fb9aeab Martina Krasteva 2021-05-27 139 * @pad: Media pad. Only one pad supported
45d19b5fb9aeab Martina Krasteva 2021-05-27 140 * @reset_gpio: Sensor reset gpio
fea91ee73b7cd1 Kieran Bingham 2023-12-11 141 * @supplies: Regulator supplies to handle power control
45d19b5fb9aeab Martina Krasteva 2021-05-27 142 * @inclk: Sensor input clock
45d19b5fb9aeab Martina Krasteva 2021-05-27 143 * @ctrl_handler: V4L2 control handler
45d19b5fb9aeab Martina Krasteva 2021-05-27 144 * @link_freq_ctrl: Pointer to link frequency control
45d19b5fb9aeab Martina Krasteva 2021-05-27 145 * @pclk_ctrl: Pointer to pixel clock control
45d19b5fb9aeab Martina Krasteva 2021-05-27 146 * @hblank_ctrl: Pointer to horizontal blanking control
45d19b5fb9aeab Martina Krasteva 2021-05-27 147 * @vblank_ctrl: Pointer to vertical blanking control
45d19b5fb9aeab Martina Krasteva 2021-05-27 148 * @exp_ctrl: Pointer to exposure control
45d19b5fb9aeab Martina Krasteva 2021-05-27 149 * @again_ctrl: Pointer to analog gain control
45d19b5fb9aeab Martina Krasteva 2021-05-27 150 * @vblank: Vertical blanking in lines
8c48b2175e7d73 Kieran Bingham 2024-03-06 151 * @lane_mode Mode for number of connected data lanes
45d19b5fb9aeab Martina Krasteva 2021-05-27 152 * @cur_mode: Pointer to current selected sensor mode
45d19b5fb9aeab Martina Krasteva 2021-05-27 153 * @mutex: Mutex for serializing sensor controls
0862582b5239a6 Umang Jain 2024-02-20 154 * @link_freq_bitmap: Menu bitmap for link_freq_ctrl
cfa49ff0558a32 Umang Jain 2023-12-11 155 * @cur_mbus_code: Currently selected media bus format code
45d19b5fb9aeab Martina Krasteva 2021-05-27 156 */
45d19b5fb9aeab Martina Krasteva 2021-05-27 157 struct imx335 {
45d19b5fb9aeab Martina Krasteva 2021-05-27 158 struct device *dev;
45d19b5fb9aeab Martina Krasteva 2021-05-27 159 struct i2c_client *client;
45d19b5fb9aeab Martina Krasteva 2021-05-27 160 struct v4l2_subdev sd;
45d19b5fb9aeab Martina Krasteva 2021-05-27 161 struct media_pad pad;
45d19b5fb9aeab Martina Krasteva 2021-05-27 162 struct gpio_desc *reset_gpio;
fea91ee73b7cd1 Kieran Bingham 2023-12-11 163 struct regulator_bulk_data supplies[ARRAY_SIZE(imx335_supply_name)];
fea91ee73b7cd1 Kieran Bingham 2023-12-11 164
45d19b5fb9aeab Martina Krasteva 2021-05-27 165 struct clk *inclk;
45d19b5fb9aeab Martina Krasteva 2021-05-27 166 struct v4l2_ctrl_handler ctrl_handler;
45d19b5fb9aeab Martina Krasteva 2021-05-27 167 struct v4l2_ctrl *link_freq_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27 168 struct v4l2_ctrl *pclk_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27 169 struct v4l2_ctrl *hblank_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27 170 struct v4l2_ctrl *vblank_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27 171 struct {
45d19b5fb9aeab Martina Krasteva 2021-05-27 172 struct v4l2_ctrl *exp_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27 173 struct v4l2_ctrl *again_ctrl;
45d19b5fb9aeab Martina Krasteva 2021-05-27 174 };
45d19b5fb9aeab Martina Krasteva 2021-05-27 175 u32 vblank;
8c48b2175e7d73 Kieran Bingham 2024-03-06 176 u32 lane_mode;
45d19b5fb9aeab Martina Krasteva 2021-05-27 177 const struct imx335_mode *cur_mode;
45d19b5fb9aeab Martina Krasteva 2021-05-27 178 struct mutex mutex;
0862582b5239a6 Umang Jain 2024-02-20 179 unsigned long link_freq_bitmap;
cfa49ff0558a32 Umang Jain 2023-12-11 180 u32 cur_mbus_code;
45d19b5fb9aeab Martina Krasteva 2021-05-27 @181 };
45d19b5fb9aeab Martina Krasteva 2021-05-27 182
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki