Re: [PATCH v6 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers

From: Rob Herring
Date: Fri Mar 08 2024 - 13:11:16 EST


On Fri, Mar 08, 2024 at 10:30:51AM -0500, Frank Li wrote:
> fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms
> have 1 interrupt.
>
> Increase max interrupt number to 2 and add restriction for platforms except
> i.MX8QXP and i.MX8QM.
>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> .../devicetree/bindings/sound/fsl,spdif.yaml | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> index 56f8c0c8afdea..a242f68f99f18 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> @@ -31,7 +31,11 @@ properties:
> maxItems: 1
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
> + items:
> + - description: Combined or receive interrupt
> + - description: Transmit interrupt

Test your patches please because this will have warnings. Or, you can
put in *exactly* what I provided because this is not it.

If you continue to just toss crap at us at the rate you are, the DT
maintainers will either just start ignoring your patches or require some
trusted review by another NXP colleague first (offhand, not sure who
that would be which is part of the problem).

Rob