Re: [PATCH 04/10] sched/debug: Increase SCHEDSTAT_VERSION to 16

From: Shrikanth Hegde
Date: Fri Mar 08 2024 - 11:40:39 EST




On 3/8/24 4:28 PM, Ingo Molnar wrote:
> We changed the order of definitions within 'enum cpu_idle_type',
> which changed the order of [CPU_MAX_IDLE_TYPES] columns in
> show_schedstat().
>

> +++ b/kernel/sched/stats.c
> @@ -113,7 +113,7 @@ void __update_stats_enqueue_sleeper(struct rq *rq, struct task_struct *p,
> * Bump this up when changing the output format or the meaning of an existing
> * format, so that tools can adapt (or abort)
> */
> -#define SCHEDSTAT_VERSION 15
> +#define SCHEDSTAT_VERSION 16

Please add the info about version, and change of the order
briefly in Documentation/scheduler/sched-stats.rst as well.

One recent user that I recollect is sched scoreboard. Version number should
be able to help the users when they it is breaking their scripts.

+Gautham, Any thoughts?

>
> static int show_schedstat(struct seq_file *seq, void *v)
> {