Re: [PATCH -next] ACPI: Add kernel-doc comments to handle_eject_request function

From: Randy Dunlap
Date: Fri Mar 08 2024 - 11:02:35 EST




On 3/7/24 23:32, Yang Li wrote:
> This patch adds proper kernel-doc comments to the
> handle_eject_request function in the ACPI dock subsystem.
>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

LGTM. Thanks.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

> ---
> drivers/acpi/dock.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index a89bdbe00184..a7c00ef78086 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -380,6 +380,8 @@ static int dock_in_progress(struct dock_station *ds)
>
> /**
> * handle_eject_request - handle an undock request checking for error conditions
> + * @ds: The dock station to undock.
> + * @event: The ACPI event number associated with the undock request.
> *
> * Check to make sure the dock device is still present, then undock and
> * hotremove all the devices that may need removing.

--
#Randy