Re: [PATCH] ASoC: soc-pcm: add the judgment of unsupported commands for the function soc_pcm_trigger
From: Mark Brown
Date: Fri Mar 08 2024 - 09:22:38 EST
On Fri, Mar 08, 2024 at 06:07:06PM +0800, xuhanwu wrote:
> Function soc_pcm_trigger, if the parameter cmd does not support the need to return an error (-EINVAL).
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
> @@ -1173,6 +1173,9 @@ static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
> if (r < 0)
> break;
> }
> + break;
> + default:
> + return -EINVAL;
> }
As can be seen from inspection of the immediately preceeding handling
of start, we're deliberately ignoring half the values in each switch.
Attachment:
signature.asc
Description: PGP signature