Re: [PATCH v3 03/11] i2c: nomadik: simplify IRQ masking logic

[Andi Shyti]

Hi Theo,

On Fri, Mar 08, 2024 at 09:57:39AM +0100, Théo Lebrun wrote:
> Hello,
> 
> On Fri Mar 8, 2024 at 12:01 AM CET, Andi Shyti wrote:
> > Hi Theo,
> >
> > On Wed, Mar 06, 2024 at 06:59:23PM +0100, Théo Lebrun wrote:
> > > IRQ_MASK and I2C_CLEAR_ALL_INTS both mask available interrupts. IRQ_MASK
> > > removes top options (bits 29-31). I2C_CLEAR_ALL_INTS removes reserved
> > > options including top bits. Keep the latter.
> > > 
> > > 31  29  27  25  23  21  19  17  15  13  11  09  07  05  03  01
> > >   30  28  26  24  22  20  18  16  14  12  10  08  06  04  02  00
> > > --- IRQ_MASK: --------------------------------------------------
> > >       1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
> > > 0 0 0
> > > --- I2C_CLEAR_ALL_INTS: ----------------------------------------
> > >       1     1 1       1 1 1 1 1                   1 1 1 1 1 1 1
> > > 0 0 0   0 0     0 0 0           0 0 0 0 0 0 0 0 0
> > > 
> > > Notice I2C_CLEAR_ALL_INTS is more restrictive than IRQ_MASK.
> > > 
> > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> >
> > You did answer my question in v2, thanks, Theo!
> 
> Oops my mailer syntax is telling me that the lines starting with '---'
> might cause issue as it might mark the end of commit messages. I'll fix
> that in next revision. If it gets applied before that it should be
> checked that part of the message doesn't get lost.

mmhhh... right! No need to resend, if nothing else is needed from
the series, please paste the commit message here and I will fix
it.

Andi