Re: [PATCH 6/9] sched/balancing: Update run_rebalance_domains() comments

[Vincent Guittot]

On Fri, 8 Mar 2024 at 11:15, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Vincent Guittot <vincent.guittot@xxxxxxxxxx> wrote:
>
> > > """
> > > The run_rebalance_domains() softirq handler is triggered via SCHED_SOFTIRQ
> > > from two places:
> > >
> > > - directly from trigger_load_balance() in scheduler_tick(), for periodic
> > >   load balance
> > >
> > > - indirectly from kick_ilb() (invoked down the scheduler_tick() too), which
> > >   issues an SMP cross-call to nohz_csd_func() which will itself raise the
> > >   softirq, for NOHZ idle balancing.
> >
> > I'm not sure that we should provide too many details of the path as
> > this might change in the future. What about the below ?
> >
> >  - directly from the local scheduler_tick() for periodic load balance
> >
> > - indirectly from a remote scheduler_tick() for NOHZ idle balancing
> > through the SMP cross-call nohz_csd_func()
>
> Okay - I updated it to:
>
>   /*
>    * This softirq handler is triggered via SCHED_SOFTIRQ from two places:
>    *
>    * - directly from the local scheduler_tick() for periodic load balancing
>    *
>    * - indirectly from a remote scheduler_tick() for NOHZ idle balancing
>    *   through the SMP cross-call nohz_csd_func()
>    */
>   static __latent_entropy void run_rebalance_domains(struct softirq_action *h)
>
> Does this work with everyone?

yes looks good for me

>
> Thanks,
>
>         Ingo